Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nextjs): Use next.js cli for build and serve targets #16896

Merged
merged 1 commit into from
May 17, 2023

Conversation

ndcunningham
Copy link
Contributor

@ndcunningham ndcunningham commented May 9, 2023

This change is to refactor @nx/next executors from using deeply imported next.js build functionality.
Now we will integrate the use of next.js CLI which should help bridge the gap between nx & next commands.

There should be no change to how the commands work for existing users.

@vercel
Copy link

vercel bot commented May 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2023 2:35pm

@ndcunningham ndcunningham self-assigned this May 9, 2023
@ndcunningham ndcunningham added the scope: nextjs Issues related to NextJS support for Nx label May 9, 2023
@jaysoo jaysoo force-pushed the feat/nextjs-cli-default branch from d4ce929 to d62be6e Compare May 15, 2023 14:23
@jaysoo jaysoo force-pushed the feat/nextjs-cli-default branch from d62be6e to 72c7adf Compare May 15, 2023 14:25
@ndcunningham ndcunningham force-pushed the feat/nextjs-cli-default branch from 72c7adf to ebeebe9 Compare May 15, 2023 14:28
@jaysoo jaysoo force-pushed the feat/nextjs-cli-default branch from 8f37db9 to a173e50 Compare May 16, 2023 13:55
@ndcunningham ndcunningham force-pushed the feat/nextjs-cli-default branch from a173e50 to a97f632 Compare May 16, 2023 14:25
@ndcunningham ndcunningham force-pushed the feat/nextjs-cli-default branch from a97f632 to 7a855f6 Compare May 16, 2023 15:11
@jaysoo jaysoo force-pushed the feat/nextjs-cli-default branch 2 times, most recently from 156c00e to 2614a25 Compare May 16, 2023 17:54
@jaysoo jaysoo force-pushed the feat/nextjs-cli-default branch from 2614a25 to e0fd200 Compare May 16, 2023 18:22
@jaysoo jaysoo force-pushed the feat/nextjs-cli-default branch from e0fd200 to eb2feee Compare May 16, 2023 18:42
@jaysoo jaysoo force-pushed the feat/nextjs-cli-default branch from eb2feee to ccc6748 Compare May 16, 2023 19:58
@jaysoo jaysoo force-pushed the feat/nextjs-cli-default branch from ccc6748 to 793e22b Compare May 16, 2023 20:30
@jaysoo jaysoo force-pushed the feat/nextjs-cli-default branch from 793e22b to c5cba27 Compare May 16, 2023 20:57
@jaysoo jaysoo disabled auto-merge May 16, 2023 20:57
@jaysoo jaysoo force-pushed the feat/nextjs-cli-default branch from c5cba27 to f961677 Compare May 17, 2023 13:45
@jaysoo jaysoo force-pushed the feat/nextjs-cli-default branch from f961677 to 11f65dd Compare May 17, 2023 14:29
@jaysoo jaysoo merged commit 3d76d95 into nrwl:master May 17, 2023
@ndcunningham ndcunningham deleted the feat/nextjs-cli-default branch May 17, 2023 15:09
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: nextjs Issues related to NextJS support for Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants