fix(nextjs): inline dev-only dependencies and add e2e test to catch issues #16890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ndcunningham
reviewed
May 9, 2023
| @@ -177,6 +177,12 @@ describe('Next.js Applications', () => { | |||
| `dist/packages/${appName}/public/shared/ui/hello.txt` | |||
| ); | |||
|
|
|||
| // Check that compiled next config does not contain bad imports | |||
| const nextConfigPath = `dist/packages/${appName}/next.config.js`; | |||
There was a problem hiding this comment.
I thought we were adding a lint rule. Is this just a stand-in until we have that set up?
There was a problem hiding this comment.
I'll add the lint rule, but also want to make sure it doesn't get into the built file in case we missed something in lint.
ndcunningham
approved these changes
May 9, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the dev-only imports to the dev/build phase only. This prevents the imports from being added to the compiled
next.config.jsfile.Current Behavior
Expected Behavior
Related Issue(s)
Fixes #16882