feat(linter): allow ESLint Flat Config to be opted into manually #16858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
meeroslav
reviewed
May 8, 2023
| if ( | ||
| useFlatConfig && | ||
| eslintConfigPath && | ||
| !eslintConfigPath?.endsWith('eslint.config.js') |
There was a problem hiding this comment.
Nit: The optional chaining on line 27 is not needed, since we check for eslintConfigPath's existence on line before
meeroslav
approved these changes
May 8, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
ESLint's new (not yet default) so called "Flat Config" cannot be used with Nx workspaces.
Expected Behavior
Users can manually opt into using ESLint's Flat Config style in their Nx workspaces prior to it being the official primary configuration style in ESLint v9 later in the year.
Appropriate migrations and generators will follow on from this once we get much closer to Flat Config being the primary default in ESLint.
https://eslint.org/docs/latest/use/configure/configuration-files-new
P.S. I also took the opportunity to clean up how ESLint is resolved and instantiated, it had become organically a bit messy over time