feat(storybook): update storybook packages to support typescript v5 #16853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
leosvelperez
force-pushed
the
storybook/ts-v5-support
branch
from
f303b06 to
2e90e6c
Compare
leosvelperez
requested review from
mandarini,
jaysoo,
Coly010,
FrozenPandaz,
vsavkin,
AgentEnder and
JamesHenry
as code owners
mandarini
approved these changes
May 8, 2023
leosvelperez
force-pushed
the
storybook/ts-v5-support
branch
from
2e90e6c to
cdb0d70
Compare
FrozenPandaz
approved these changes
May 8, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
A new patch version of Storybook adds support for TS v5. Workspaces that added Storybook before that version won't have it and their package installation could be complaining about wrong peer dependencies. This is especially true in Angular v16 workspaces that use TS v5 by default.
Expected Behavior
The Storybook packages are guaranteed to use a version that supports TS v5.
Note: The new version still supports TS v4 as well so it's not a breaking change for workspaces using TS v4.
Related Issue(s)
Fixes #