fix(core): increase interval attempts for daemon server available on … #16813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…start For larger workspaces the start up of the daemon server can take some take due to the initialisation of the hasher. By increasing the attempts the client will poll longer for the server to connect closed nrwl#16809
Roozenboom
requested review from
vsavkin,
FrozenPandaz and
AgentEnder
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…mon-server-available-attempts
AgentEnder
approved these changes
May 17, 2023
|
@AgentEnder can we get this merged? I'm seeing the issue in the docker build for a large code base, and how does this affect lerna? will it publish another lerna version? (I'm not using nx directly) |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…start
For larger workspaces the start-up of the daemon server can take some take due to the initialization of the hasher.
By increasing the attempts the client will poll longer for the server to connect
closed #16809
Current Behavior
The daemon client waits 10 seconds for the daemon server to be available. This isn't enough for workspaces that contain a lot of files because the server also initialized the hasher on start-up.
Expected Behavior
By increasing the attempts to 6000 the client will wait for a minute, which gives the server more time to start up also in large workspaces
Related Issue(s)
Fixes #16809