feat(angular): add ngrx feature store generator #16806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coly010
requested review from
bcabanes,
FrozenPandaz,
jaysoo,
AgentEnder,
isaacplmann and
juristr
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Coly010
force-pushed
the
angular/ngrx-root-generator
branch
from
fde2e6f to
22fe560
Compare
AgentEnder
approved these changes
May 5, 2023
leosvelperez
approved these changes
May 9, 2023
MaxKless
pushed a commit
that referenced
this pull request
May 10, 2023
MaxKless
pushed a commit
that referenced
this pull request
May 10, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
We have one NgRx Generator that currently tries to handle two different use cases and as such has come conflicting logic and a lot of branching to determine which use case to run.
Expected Behavior
We should have two separate generators that focus purely on each use case:
This PR addresses 2.
There are cases when there should also be a root state, so the root state generator can then invoke this generator for that case.
Related Issue(s)
Fixes #