feat(core): log a note after an interactive migration run with skipped package updates #16802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
leosvelperez
changed the title
leosvelperez
force-pushed
the
core/migrate-recommend-command-skipped-updates
branch
from
743df6e to
c0f45a6
Compare
leosvelperez
requested review from
vsavkin,
FrozenPandaz and
AgentEnder
as code owners
leosvelperez
force-pushed
the
core/migrate-recommend-command-skipped-updates
branch
from
c0f45a6 to
be45f2a
Compare
leosvelperez
force-pushed
the
core/migrate-recommend-command-skipped-updates
branch
from
be45f2a to
1180fc7
Compare
leosvelperez
force-pushed
the
core/migrate-recommend-command-skipped-updates
branch
from
1180fc7 to
15be712
Compare
leosvelperez
requested review from
bcabanes,
isaacplmann and
juristr
as code owners
isaacplmann
requested changes
May 9, 2023
|
Looks good in general. I just simplified a few of your sentences. |
leosvelperez
force-pushed
the
core/migrate-recommend-command-skipped-updates
branch
from
15be712 to
ee7a95d
Compare
leosvelperez
force-pushed
the
core/migrate-recommend-command-skipped-updates
branch
from
ee7a95d to
eb2e5cf
Compare
…d package updates
leosvelperez
force-pushed
the
core/migrate-recommend-command-skipped-updates
branch
from
b9ebfa8 to
40534da
Compare
FrozenPandaz
approved these changes
May 15, 2023
isaacplmann
approved these changes
May 15, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When running migrations in interactive mode, if the user opts out of any package update, there's no feedback or recommendation about how to later apply those skipped package updates. It's particularly important to provide feedback about the
--fromversion to use with themigratecommand to apply those changes.Expected Behavior
When running migrations in interactive mode, if the user opts out of any package update, a next step is printed to the terminal with a recommended command to run later to apply skipped changes. The link to learn more is also changed to the advanced migration guide. When migrations are not run in interactive mode or there are no skipped updates, we still get the current messaging.
Related Issue(s)
Fixes #