Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): register task timings correctly in task profiling life cycle #16801

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented May 5, 2023

Current Behavior

In the TaskProfilingLifeCycle class the task timings are registered with a manually crafted key instead of using the task id. When processing the task results, timings are set with the task id which throws because of the mismatch.

Expected Behavior

In the TaskProfilingLifeCycle class the task timings should be registered with the task id.

Related Issue(s)

Fixes #16792

@leosvelperez leosvelperez requested a review from vsavkin as a code owner May 5, 2023 09:58
@leosvelperez leosvelperez self-assigned this May 5, 2023
@vercel
Copy link

vercel bot commented May 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2023 10:03am

@FrozenPandaz FrozenPandaz merged commit 1d8be1c into nrwl:master May 5, 2023
@leosvelperez leosvelperez deleted the core/fix-profiling-lifecycle-task-registration branch May 8, 2023 08:19
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profiling build performance (NX_PROFILE) throws error (even in brand-new repo)
3 participants