Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): allow using project patterns rather than just project names with nx watch #16768

Merged

Conversation

AgentEnder
Copy link
Member

@AgentEnder AgentEnder commented May 4, 2023

Current Behavior

nx watch accepts a list of project names via --projects, but doesn't use findMatchingProjects and thus has inconsistencies with run-many, affected (--exclude), implicitDependencies, dependsOn, and inputs

Expected Behavior

All projects fields use findMatchingProjects

Related Issue(s)

Fixes #16761

@vercel
Copy link

vercel bot commented May 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2023 8:08pm

@AgentEnder AgentEnder force-pushed the feat/use-find-matching-projects-for-watch branch from 74cfb96 to 8e2d244 Compare May 4, 2023 15:06
@AgentEnder AgentEnder force-pushed the feat/use-find-matching-projects-for-watch branch from 8e2d244 to df0a9b8 Compare May 4, 2023 15:13
@AgentEnder AgentEnder force-pushed the feat/use-find-matching-projects-for-watch branch from df0a9b8 to 837455f Compare May 4, 2023 15:26
@AgentEnder AgentEnder force-pushed the feat/use-find-matching-projects-for-watch branch from 837455f to a83deac Compare May 4, 2023 19:08
@AgentEnder AgentEnder force-pushed the feat/use-find-matching-projects-for-watch branch from a83deac to 0555f3b Compare May 5, 2023 20:04
@AgentEnder AgentEnder enabled auto-merge (squash) May 5, 2023 20:19
@AgentEnder AgentEnder merged commit 842c412 into nrwl:master May 5, 2023
@dstoyanoff
Copy link

Hello @AgentEnder, which version should that be part of? Don't see it in the release notes and it also doesn't work for me with 16.1.3. Thanks

@AgentEnder
Copy link
Member Author

Its not released yet, but should be part of 16.2.0 whenever it lands

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support run-many options in watch
3 participants