-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react-native): fix buildable react native library #16749
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiongemi
requested review from
jaysoo,
ndcunningham,
bcabanes,
isaacplmann and
juristr
as code owners
May 3, 2023 22:03
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
xiongemi
force-pushed
the
bugfix/fix-build-react-native-lib
branch
from
May 3, 2023 22:19
140749e
to
74529e0
Compare
xiongemi
force-pushed
the
bugfix/fix-build-react-native-lib
branch
from
May 5, 2023 18:45
74529e0
to
5b907e9
Compare
xiongemi
force-pushed
the
bugfix/fix-build-react-native-lib
branch
from
May 5, 2023 19:37
5b907e9
to
8a1f3de
Compare
jaysoo
approved these changes
May 5, 2023
LGTM Future: Let's look at Vite for the buildable libraries as well since we support it for React/Web. |
bcabanes
approved these changes
May 9, 2023
xiongemi
force-pushed
the
bugfix/fix-build-react-native-lib
branch
from
May 9, 2023 16:07
8a1f3de
to
610ad7d
Compare
FrozenPandaz
pushed a commit
that referenced
this pull request
May 9, 2023
(cherry picked from commit 8347e61)
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
currently react native and expo library uses rollup to build libraries; however, it does not install @nx/rollup when adding a buildable library.
Expected Behavior
when adding a buildable library, it should add @nx/rollup to devDependencies.
Related Issue(s)
Fixes #