Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-native): fix buildable react native library #16749

Merged
merged 1 commit into from
May 9, 2023

Conversation

xiongemi
Copy link
Collaborator

@xiongemi xiongemi commented May 3, 2023

Current Behavior

currently react native and expo library uses rollup to build libraries; however, it does not install @nx/rollup when adding a buildable library.

Expected Behavior

when adding a buildable library, it should add @nx/rollup to devDependencies.

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented May 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 9, 2023 4:13pm

@jaysoo
Copy link
Member

jaysoo commented May 5, 2023

LGTM

Future: Let's look at Vite for the buildable libraries as well since we support it for React/Web.

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2023
@xiongemi xiongemi deleted the bugfix/fix-build-react-native-lib branch June 8, 2023 15:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants