Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): ignore nx storybook plugin from sb eslint #16725

Merged
merged 1 commit into from
May 4, 2023

Conversation

mandarini
Copy link
Member

@mandarini mandarini commented May 3, 2023

Current Behavior

If workspace uses plugin:storybook/recommended eslint plugin and @nx/react/plugins/storybook storybook addon, then a linting error is thrown, because it cannot see that the plugin is installed. Reference: storybookjs/eslint-plugin-storybook#129

Expected Behavior

If @nx/react/plugins/storybook and workspace uses the plugin:storybook/recommended eslint plugin, then ignore our package from the no-uninstalled-addons rule.

Also, add this rule to our .eslintrc.json.

Related Issue(s)

#16629

@vercel
Copy link

vercel bot commented May 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2023 5:19pm

@mandarini mandarini requested a review from jaysoo May 3, 2023 17:35
@mandarini mandarini enabled auto-merge (squash) May 3, 2023 17:56
Copy link
Contributor

@meeroslav meeroslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the leftover console.log, looks good

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@nx/react/plugins/storybook is not installed after migrating to 16.0.0
6 participants