fix(angular): clean up ssr main.server.ts generation #16699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
leosvelperez
force-pushed
the
angular/fix-ssr-generation
branch
from
feb942b to
0818da5
Compare
leosvelperez
force-pushed
the
angular/fix-ssr-generation
branch
from
0818da5 to
44955aa
Compare
Coly010
approved these changes
May 2, 2023
FrozenPandaz
pushed a commit
that referenced
this pull request
May 2, 2023
(cherry picked from commit 4be6f74)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
@angular/platform-server/initis imported in generatedmain.server.ts. This is not needed since Angular v15 (angular/angular-cli@979bce4).renderModulesymbol from@angular/platform-serveris exported. This is not needed since Angular v15 (angular/angular-cli@15d3fc6). A migration was run to remove it when Angular v15 came out, but the generator kept generating this.Expected Behavior
@angular/platform-server/initis not imported in generatedmain.server.tsfor Angular v15 or later. It's still generated for Angular v14.renderModulesymbol from@angular/platform-serveris not exported for Angular v15 or later. It's still generated for Angular v14.Note: I duplicated the migration that was run when Nx 15.2.0 came out (version that added Angular v15 support) so we can correct any new generation that happened after that.
Related Issue(s)
Fixes #