Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): support matching projects specifiers in dependsOn #16675

Merged

Conversation

AgentEnder
Copy link
Member

@AgentEnder AgentEnder commented May 1, 2023

Current Behavior

findMatchingProjects is used for the --projects flag (affected, run-many etc), --exclude, and implicitDependencies

Expected Behavior

Anywhere that we allow a field called projects supports findMatchingProjects

Related Issue(s)

Fixes #16138

@vercel
Copy link

vercel bot commented May 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2023 7:31pm

@AgentEnder AgentEnder force-pushed the feat/use-matching-projects-for-dependsOn branch from 3115236 to febc9a0 Compare May 1, 2023 22:16
@AgentEnder AgentEnder force-pushed the feat/use-matching-projects-for-dependsOn branch from febc9a0 to a2e70f1 Compare May 2, 2023 15:16
@AgentEnder AgentEnder requested a review from FrozenPandaz May 2, 2023 18:39
output.warn({
title: `\`dependsOn\` is misconfigured for ${task.target.project}:${task.target.target}`,
bodyLines: [
`Project pattern ${projectSpecifier} matches 0 projects.`,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`Project pattern ${projectSpecifier} matches 0 projects.`,
`Project pattern ${projectSpecifier} does not match any projects.`,

@github-actions
Copy link

github-actions bot commented May 8, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DependsOn project target does not work as expected
2 participants