-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): support matching projects specifiers in dependsOn #16675
Merged
AgentEnder
merged 1 commit into
nrwl:master
from
AgentEnder:feat/use-matching-projects-for-dependsOn
May 2, 2023
Merged
feat(core): support matching projects specifiers in dependsOn #16675
AgentEnder
merged 1 commit into
nrwl:master
from
AgentEnder:feat/use-matching-projects-for-dependsOn
May 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
FrozenPandaz
requested changes
May 1, 2023
AgentEnder
force-pushed
the
feat/use-matching-projects-for-dependsOn
branch
from
May 1, 2023 22:16
3115236
to
febc9a0
Compare
FrozenPandaz
requested changes
May 1, 2023
AgentEnder
force-pushed
the
feat/use-matching-projects-for-dependsOn
branch
from
May 2, 2023 15:16
febc9a0
to
a2e70f1
Compare
FrozenPandaz
approved these changes
May 2, 2023
output.warn({ | ||
title: `\`dependsOn\` is misconfigured for ${task.target.project}:${task.target.target}`, | ||
bodyLines: [ | ||
`Project pattern ${projectSpecifier} matches 0 projects.`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
`Project pattern ${projectSpecifier} matches 0 projects.`, | |
`Project pattern ${projectSpecifier} does not match any projects.`, |
AgentEnder
force-pushed
the
feat/use-matching-projects-for-dependsOn
branch
from
May 2, 2023 19:28
a2e70f1
to
200b134
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
findMatchingProjects
is used for the--projects
flag (affected, run-many etc),--exclude
, andimplicitDependencies
Expected Behavior
Anywhere that we allow a field called
projects
supportsfindMatchingProjects
Related Issue(s)
Fixes #16138