Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel options nx.json tasksRunnnerOptions are Ignored in Nx 16 #16662

Closed
pumano opened this issue Apr 30, 2023 · 4 comments
Closed

Parallel options nx.json tasksRunnnerOptions are Ignored in Nx 16 #16662

pumano opened this issue Apr 30, 2023 · 4 comments
Assignees
Labels

Comments

@pumano
Copy link
Contributor

pumano commented Apr 30, 2023

Current Behavior

nx run-many --exclude=some-libs --target=lint --quiet run only 3 parallel default jobs

Expected Behavior

run parallel jobs based on information from nx.json tasksRunnerOptions (I have 6)

workaround: add --parallel=6 manually to command

GitHub Repo

No response

Steps to Reproduce

  1. nx 16
  2. angular 16

Nx Report

Node   : 18.13.0
   OS     : darwin arm64
   yarn   : 3.5.0
   Hasher : Native
   
   nx                 : 16.0.1
   @nx/js             : 16.0.1
   @nx/jest           : 16.0.1
   @nx/linter         : 16.0.1
   @nx/workspace      : 16.0.1
   @nx/angular        : 16.0.1
   @nx/cypress        : 16.0.1
   @nx/devkit         : 16.0.1
   @nx/eslint-plugin  : 16.0.1
   @nx/storybook      : 16.0.1
   @nrwl/tao          : 16.0.1
   @nx/webpack        : 16.0.1
   typescript         : 4.9.5
   ---------------------------------------
   Community plugins:
   @ngneat/transloco     : 4.2.6
   @ngrx/component-store : 15.4.0
   @ngrx/effects         : 15.4.0
   @ngrx/entity          : 15.4.0
   @ngrx/router-store    : 15.4.0
   @ngrx/store           : 15.4.0
   @ngrx/store-devtools  : 15.4.0
   @ngneat/spectator     : 14.0.0
   @ngrx/eslint-plugin   : 15.4.0
   @ngrx/schematics      : 15.4.0
   @storybook/angular    : 7.0.7
   nx-stylelint          : 15.0.0

Failure Logs

No response

Additional Information

Screenshot 2023-04-30 at 20 53 08

only 3 jobs in parallel

That is regression previous versions works good

previous bug #10756

@AgentEnder AgentEnder added the scope: core core nx functionality label Apr 30, 2023
@AgentEnder AgentEnder self-assigned this Apr 30, 2023
@jsaguet
Copy link
Contributor

jsaguet commented May 1, 2023

I'm seeing the same issue.

It looks like this bug was introduced in #13837

It seems to me that the expected behavior should be to use the runner's parallel option when --parallel flag is provided without a value or not provided at all instead of forcing it to 3.
It means the above PR should be reverted but it would bring back the old behavior described in #13782

I could open a PR to fix this but I'm not sure what the expected solution is.

@pumano
Copy link
Contributor Author

pumano commented May 2, 2023

Looks like #13782 about when is not set default should be 1, but works when change it to another value. Looks like 1 (sequentional running) is very slow when you processing large amount of libs, and it's bad as defaults. More over 3 is really bad too. Maybe use 6 as default (mostly modern CPU provide 6+ cores) or maybe when create project check available cores and provide better values or check when running and tell if user can use more cores for it.

But my bug about I can't set parallel from nx.json

@AgentEnder
Copy link
Member

This is fixed by: #16707

@github-actions
Copy link

github-actions bot commented Jun 2, 2023

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants