feat(core): update dependsOn configuration to use dependencies property #16584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgentEnder
requested review from
FrozenPandaz,
vsavkin,
bcabanes,
isaacplmann and
juristr
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
vsavkin
approved these changes
Apr 26, 2023
AgentEnder
commented
Apr 26, 2023
packages/nx/src/hasher/hasher.ts
Outdated
| const partialHashes: Promise<PartialHash[]>[] = []; | ||
| for (const input of projectInputs) { | ||
| for (const project of input.projects) { | ||
| console.log(project, this.projectGraph.nodes[project]); |
AgentEnder
commented
Apr 26, 2023
packages/nx/src/hasher/hasher.ts
Outdated
| this.nxJson, | ||
| this.projectGraph.nodes[project] | ||
| ); | ||
| const expandedInput = expandSelfInputs( |
There was a problem hiding this comment.
expandSingleProjectInputs
AgentEnder
commented
Apr 26, 2023
packages/nx/src/hasher/hasher.ts
Outdated
| [{ input: input.input }], | ||
| namedInputs | ||
| ); | ||
| partialHashes.push(this.hashSelfInputs(project, expandedInput)); |
There was a problem hiding this comment.
hashSingleProjectInputs
AgentEnder
force-pushed
the
feat/update-depends-on-config
branch
from
eda9a3c to
f10c32d
Compare
AgentEnder
force-pushed
the
feat/update-depends-on-config
branch
2 times, most recently
from
2e47682 to
3941696
Compare
AgentEnder
force-pushed
the
feat/update-depends-on-config
branch
from
3941696 to
8c9041d
Compare
AgentEnder
changed the title
This was referenced Apr 28, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ty rather than tokens
Current Behavior
We introduced {self} and {dependencies} for TargetDependencyConfig['projects'], but have decided to move in a slightly different direction.
Expected Behavior
Instead, we use the lack of a
projectsfield to indicateself, and a fielddependencies: trueto indicatedependencies.Also, this is equivalent for hashing and
inputs.Related Issue(s)
Fixes #