Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(repo): replace remaining instances of yarn with pnpm #16571

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

meeroslav
Copy link
Contributor

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Apr 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 27, 2023 10:00am

scripts/commitizen.js Outdated Show resolved Hide resolved
@nx-cloud
Copy link

nx-cloud bot commented Apr 26, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2572b0a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@meeroslav meeroslav force-pushed the chore-fix-yarn-leftovers branch 2 times, most recently from 4a8d2f3 to 7673b6f Compare April 27, 2023 08:16
@meeroslav meeroslav force-pushed the chore-fix-yarn-leftovers branch 2 times, most recently from 1570e7c to 46c6be6 Compare April 27, 2023 09:44
@@ -102,7 +102,7 @@
},
"generateLockfile": {
"type": "boolean",
"description": "Generate a lockfile (e.g. yarn.lock) that matches the workspace lockfile to ensure package versions match.",
"description": "Generate a lockfile (e.g. package-lock.json) that matches the workspace lockfile to ensure package versions match.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine but is there a reason we replaced the description in the schemas as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The npm package manager is far more used, so it makes sense to have that as a default example.
Doesn't break anything, just our docs are full of references to yarn despite it not being the most common choice.

@AgentEnder AgentEnder merged commit f004e22 into nrwl:master Apr 27, 2023
@github-actions
Copy link

github-actions bot commented May 4, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants