fix(core): handle symbol in migration path and infer angular material and cdk migration type correctly #16538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
leosvelperez
force-pushed
the
core/fix-migrations-path-resolution-and-type-inference
branch
from
b0a214f to
9dfaccb
Compare
leosvelperez
requested review from
vsavkin,
FrozenPandaz and
AgentEnder
as code owners
AgentEnder
approved these changes
Apr 25, 2023
|
@leosvelperez I think if you rebase this it should go through |
leosvelperez
force-pushed
the
core/fix-migrations-path-resolution-and-type-inference
branch
from
9dfaccb to
5cc9f7b
Compare
… and cdk migration type correctly
leosvelperez
force-pushed
the
core/fix-migrations-path-resolution-and-type-inference
branch
from
5cc9f7b to
5316b66
Compare
leosvelperez
deleted the
core/fix-migrations-path-resolution-and-type-inference
branch
This was referenced Apr 28, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The
nx migratecommand throws when a migration path contains the exported migration function symbol.The
nx migratecommand doesn't identify migrations from Angular Material and Angular CDK as migrations implemented with the Angular DevKit.Expected Behavior
The
nx migratecommand should support migration paths containing the exported migration function symbol.The
nx migratecommand should correctly identify Angular Material and Angular CDK as migrations implemented with the Angular DevKit.Related Issue(s)
Fixes #