fix(node): use consistent default port

[philipjfulcher]

Current Behavior

The Node application generator has two different default ports: 3000 in the schema.json and 3333 in the generator itself. This results in a failing e2e test after generation.

Expected Behavior

The default port is consistent.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
nx-dev	⬜️ Ignored (Inspect)			Apr 24, 2023 2:41am

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 883f456. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 8 targets

• nx affected -t e2e-macos --parallel=1 --exclude=e2e-detox
• nx affected --target=e2e --base=b3a8ac3cb8a3d469a80aad7a0541719722c0a54e --head=883f4561a41e89e921db49a64da162f1e7b18d1b --parallel=1
• nx affected --target=test --base=b3a8ac3cb8a3d469a80aad7a0541719722c0a54e --head=883f4561a41e89e921db49a64da162f1e7b18d1b --parallel=1
• nx run-many -t check-imports check-commit check-lock-files depcheck --parallel=1 --no-dte
• nx affected --target=build --base=b3a8ac3cb8a3d469a80aad7a0541719722c0a54e --head=883f4561a41e89e921db49a64da162f1e7b18d1b --parallel=3
• nx affected --target=lint --base=b3a8ac3cb8a3d469a80aad7a0541719722c0a54e --head=883f4561a41e89e921db49a64da162f1e7b18d1b --parallel=3
• nx-cloud record -- nx format:check --base=b3a8ac3cb8a3d469a80aad7a0541719722c0a54e --head=883f4561a41e89e921db49a64da162f1e7b18d1b
• nx documentation --no-dte

---

Sent with 💌 from NxCloud.

[nartc]

Some frontend generators use port 3333 to setup proxy conf if consumers pass in --backendProject. Can we change the default in schema.json to 3333 instead?

[philipjfulcher]

Some frontend generators use port 3333 to setup proxy conf if consumers pass in --backendProject. Can we change the default in schema.json to 3333 instead?

If we do that, we would also need to change the default port for the e2e. I see one place that backendProject is used: https://github.com/nrwl/nx/blob/master/packages/angular/src/generators/application/lib/add-proxy-config.ts

3333 is hard-coded as the port. I don't think that's safe, given that a backend project could be running off any port, even if we change the default. It also assumes the url will be the same name as the backend project. From my very limited perspective, it would be a better idea to change those frontend generators to accept something like a proxyUrl and a proxyTarget config where the user could provide the values instead of trying to make assumptions.

I think the problems with that generator exist no matter if we change the defaults here. I could change the default port in those frontend generators to also be 3000 to get everything lined up and at least working out of the box.

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.