fix(nextjs): support workspace libs with standalone Next.js app #16471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jaysoo
commented
Apr 21, 2023
| @@ -152,14 +152,14 @@ describe('next library', () => { | |||
| expect(appTree.read('my-lib/src/index.ts', 'utf-8')).toContain( | |||
| 'React client components' | |||
| ); | |||
| expect(appTree.read('my-lib/src/server.ts', 'utf-8')).toContain( | |||
| expect(appTree.read('my-lib/src/server.tsx', 'utf-8')).toContain( | |||
There was a problem hiding this comment.
Had to generate with a default component, otherwise the Standalone app complains about no exports being found from module.
jaysoo
requested review from
ndcunningham,
xiongemi and
mandarini
as code owners
ndcunningham
approved these changes
Apr 21, 2023
jaysoo
force-pushed
the
fix/nextjs-standalone-with-libs
branch
from
4c7093c to
0130b11
Compare
ndcunningham
approved these changes
Apr 21, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the setup when generating and using workspace libs in a Next.js standalone app.
@nx/next:libis used, babel files should not be generated since we are using SWC.compilerOptions.paths: {}should not exist for standalonetsconfig.json, because migrating after generating lib will override the base paths intsconfig.base.jsonfile.