fix(core): fix cache recalculation #16468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
FrozenPandaz
requested review from
nartc,
jaysoo and
ndcunningham
as code owners
nartc
approved these changes
Apr 21, 2023
AgentEnder
approved these changes
Apr 21, 2023
FrozenPandaz
added a commit
that referenced
this pull request
Apr 24, 2023
(cherry picked from commit a10b6b1)
FrozenPandaz
added a commit
that referenced
this pull request
Apr 24, 2023
(cherry picked from commit a10b6b1)
FrozenPandaz
added a commit
that referenced
this pull request
Apr 25, 2023
(cherry picked from commit a10b6b1)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When the nx cache is checked, the version that is being compared, is the version in the workspace's
package.json. So even ifinstallhas not been run yet, it will report that it calculated the graph with the new version. Thus, when the new version is actually installed, it will not need to recalculate the graph.Expected Behavior
When the nx cache is checked, the version being compared will be the installed version of
nx. So ifinstallhasn't been run yet, it will reuse the cache. But when the new version is installed, it will recalculate.Related Issue(s)
Fixes #