Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linter): fix legacy linter migrations #16462

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

FrozenPandaz
Copy link
Collaborator

Current Behavior

@nrwl/eslint-plugin-nx migrations are not running.

Expected Behavior

@nrwl/eslint-plugin-nx migrations run and have been run on this repo.

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Apr 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 21, 2023 3:58pm

@@ -30,6 +30,6 @@
"access": "public"
},
"nx-migrations": {
"migrations": "@nx/eslint-plugin-nx/migrations.json"
"migrations": "@nx/eslint-plugin/migrations.json"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the main issue here.

Copy link
Contributor

@meeroslav meeroslav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@FrozenPandaz FrozenPandaz merged commit 88b9687 into nrwl:master Apr 21, 2023
@FrozenPandaz FrozenPandaz deleted the fix-rescope-linter branch April 21, 2023 17:29
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants