Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): swapped fragments with <div> so avoid lint warnings for default #16449

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Apr 20, 2023

Now that the empty <div/> is removed, the unnecessary <></> fragments are causing lint warnings for the linter e2e tests. This PR sets them to <div></div> to avoid the warning. Removing the fragments completely breaks the AST utils to add routes to the app, since it is currently expecting at least one set of open-close JSX element.

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Apr 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Apr 20, 2023 8:53pm

@jaysoo jaysoo marked this pull request as ready for review April 20, 2023 20:54
@jaysoo jaysoo enabled auto-merge (squash) April 20, 2023 21:00
@jaysoo jaysoo merged commit db6e14e into nrwl:master Apr 20, 2023
@jaysoo jaysoo deleted the fix/react-lint-warnings branch April 20, 2023 21:39
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants