Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): only check existence of storybook before migrating #16431

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

mandarini
Copy link
Member

Change migrator to just check if Storybook is installed in the workspace.
Before, it would check if Storybook is already in v7. The thing here is that during the previous step of the migration, during packageJsonUpdates, Nx has already set Storybook to version 7, if Storybook exists in the workspace.
So, it makes no sense here to check if the version is 7, because it will always be. The migrate-7 generator will handle the logic of whether it needs to actually run any migrations or not.

@vercel
Copy link

vercel bot commented Apr 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Apr 20, 2023 11:09am

@mandarini mandarini self-assigned this Apr 20, 2023
@mandarini mandarini enabled auto-merge (squash) April 20, 2023 11:14
@mandarini mandarini merged commit e447f2c into nrwl:master Apr 20, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants