fix(core): whitelist registries that support obtaining migration config via 'npm view' #16423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ig via 'npm view' Registries other than npmjs.org may not support obtaining non standard package metadata via 'npm view'. In the event that migration config is not returned when using other registries, migration will fallback to determining config using install. closed nrwl#16387, nrwl#10223
CNManning
requested review from
vsavkin,
FrozenPandaz and
AgentEnder
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
AgentEnder
approved these changes
Apr 20, 2023
|
|
||
| // Registries other than npmjs and the local registry may not support full metadata via npm view | ||
| // so throw error so that fetcher falls back to getting config via install | ||
| if (!['registry.npmjs.org', 'localhost'].includes(registry)) { |
There was a problem hiding this comment.
Yarn's registry just redirects to npmjs, and can be in lock files, but still shows npm's url for the tarball 🤔 interesting.
I think this is fine.
FrozenPandaz
approved these changes
Apr 20, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Determining migration config for plugins that are published to a different registry than npmjs.org doesn't work if the registry doesn't support full package metadata. Such registries return no results via 'npm view' which causes migrate to think that no migrations are necessary.
Expected Behavior
Migrate will fallback to determining migration config via install in the event that no config is returned from 'npm view' for registries other then npmjs.org.
Related Issue(s)
Fixes #16387, #10223