fix(misc): handle packages rescope in nx init flows #16404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
FrozenPandaz
requested changes
Apr 19, 2023
leosvelperez
force-pushed
the
misc/nx-init-reescope-support
branch
from
84176d9 to
3b679b0
Compare
leosvelperez
requested review from
AgentEnder,
vsavkin,
jaysoo,
xiongemi,
mandarini and
Coly010
as code owners
Coly010
approved these changes
Apr 19, 2023
leosvelperez
changed the title
FrozenPandaz
approved these changes
Apr 19, 2023
mandarini
approved these changes
Apr 20, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Some
nx initflows reference the@nrwlscope and don't handle the new@nxscope. The E2E tests for the CRA flow check the presence of the packages with the old scopes.Expected Behavior
The
nx initflows reference the new@nxscope and handle the old one where needed (e.g. for Angular CLI legacy versions). The E2E tests for the CRA flow only check the presence of the packages with the new scopes.Related Issue(s)
Fixes #