-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(angular): add migration to remove karma generator defaults #16400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
leosvelperez
requested changes
Apr 19, 2023
packages/angular/src/migrations/update-16-0-0/remove-karma-defaults.ts
Outdated
Show resolved
Hide resolved
packages/angular/src/migrations/update-16-0-0/remove-karma-defaults.ts
Outdated
Show resolved
Hide resolved
Coly010
force-pushed
the
remove-karma-defaults-migration
branch
from
April 19, 2023 12:51
c86c489
to
f12139c
Compare
leosvelperez
requested changes
Apr 20, 2023
packages/angular/src/migrations/update-16-0-0/remove-karma-defaults.ts
Outdated
Show resolved
Hide resolved
packages/angular/src/migrations/update-16-0-0/remove-karma-defaults.ts
Outdated
Show resolved
Hide resolved
Coly010
force-pushed
the
remove-karma-defaults-migration
branch
from
April 20, 2023 15:45
f12139c
to
0cf75a8
Compare
Coly010
force-pushed
the
remove-karma-defaults-migration
branch
from
April 20, 2023 21:29
0cf75a8
to
08bb1cc
Compare
leosvelperez
requested changes
Apr 21, 2023
Coly010
force-pushed
the
remove-karma-defaults-migration
branch
from
April 21, 2023 08:30
08bb1cc
to
7109746
Compare
leosvelperez
approved these changes
Apr 21, 2023
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Some generator defaults in nxJson and Project Configurations may point to Karma
Expected Behavior
We do not support generating with Karma as the unit test runner anymore so remove these defaults
Related Issue(s)
Fixes #