Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): add migration to remove karma generator defaults #16400

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Apr 19, 2023

Current Behavior

Some generator defaults in nxJson and Project Configurations may point to Karma

Expected Behavior

We do not support generating with Karma as the unit test runner anymore so remove these defaults

Related Issue(s)

Fixes #

@Coly010 Coly010 requested a review from leosvelperez as a code owner April 19, 2023 10:23
@Coly010 Coly010 self-assigned this Apr 19, 2023
@vercel
Copy link

vercel bot commented Apr 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Apr 21, 2023 8:31am

@Coly010 Coly010 force-pushed the remove-karma-defaults-migration branch from c86c489 to f12139c Compare April 19, 2023 12:51
@Coly010 Coly010 requested a review from leosvelperez April 19, 2023 12:52
@Coly010 Coly010 force-pushed the remove-karma-defaults-migration branch from f12139c to 0cf75a8 Compare April 20, 2023 15:45
@Coly010 Coly010 requested a review from leosvelperez April 20, 2023 15:47
@Coly010 Coly010 force-pushed the remove-karma-defaults-migration branch from 0cf75a8 to 08bb1cc Compare April 20, 2023 21:29
packages/angular/migrations.json Outdated Show resolved Hide resolved
@Coly010 Coly010 force-pushed the remove-karma-defaults-migration branch from 08bb1cc to 7109746 Compare April 21, 2023 08:30
@Coly010 Coly010 requested a review from leosvelperez April 21, 2023 08:33
@Coly010 Coly010 enabled auto-merge (squash) April 21, 2023 08:48
@Coly010 Coly010 merged commit 14d9a8b into nrwl:master Apr 21, 2023
@Coly010 Coly010 deleted the remove-karma-defaults-migration branch April 21, 2023 09:03
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants