-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[react][storybook] Nx add NOT needed deps on new lib setup #16395
Comments
Hi there @ild0tt0re ! Thanks for filing an issue! Please help me understand, if you are using Storybook, how come
are not needed? Or do you mean you need these, but with the version you already have installed? |
Yeah, if they need to be installed I expect should be at the same version of others storybook packages, like:
Probably only the two dependencies that you mention need to be installed, also if we have |
Ok, @ild0tt0re this is not only an issue with the |
I am changing the scope to React, here, since the extra dependencies are installed during the The Storybook part of this issue was fixed in above PR, which was to use the version that the user has already installed. So, to sum up, the expected behaviour as noted by @ild0tt0re is:
Part 1 ("generating a new lib should not force installation of hardcoded/wrong packages different from what is installed in the monorepo") was covered by #16405 and #16408. Part 2 is "should not install the deps at all since the package manager can be configured in different way", which is something we need to discuss if we want? |
Actually, @ild0tt0re, I think |
This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context. |
Current Behavior
When we create a new react library with a storybook configuration, the following not needed libs are installed:
NOTE:
auto-install-peers=true
installation withpnpm
package manager"7.0.2"
version but it install"^7.0.0-rc.0"
Expected Behavior
Generating a new lib should not force installation of hardcoded/wrong packages different from what is installed in the monorepo, or should not install the deps at all since the package manager can be configured in different way.
GitHub Repo
No response
Steps to Reproduce
Nx Report
Additional Information
I understand that Nx want to check that needed packages are installed during the generation of specific lib with its tech stack, but since is hard to understand each use case and package manager configuration I would like to have an option/flag to skip the packages installation part.
Requested also here #5018
The text was updated successfully, but these errors were encountered: