Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(misc): update @swc/helpers version to match @swc/core #16343

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Apr 17, 2023

@swc/core has a peer dep on @swc/helpers, but ours is out of date so it's leading to an issue like the following:

 npm ERR! ERESOLVE could not resolve
    npm ERR! 
    npm ERR! While resolving: @swc/[email protected]
    npm ERR! Found: @swc/[email protected]
    npm ERR! node_modules/@swc/helpers
    npm ERR!   dev @swc/helpers@"~0.4.11" from the root project
    npm ERR!   @swc/helpers@"^0.4.11" from @nx/[email protected]
    npm ERR!   node_modules/@nx/vite
    npm ERR!     @nx/vite@"16.0.0" from @nrwl/[email protected]
    npm ERR!     node_modules/@nrwl/vite
    npm ERR!       dev @nrwl/vite@"^16.0.0" from the root project
    npm ERR!       1 more (@nx/vite)
    npm ERR!   1 more (next)
    npm ERR! 
    npm ERR! Could not resolve dependency:
    npm ERR! peerOptional @swc/helpers@"^0.5.0" from @swc/[email protected]
    npm ERR! node_modules/@swc/core
    npm ERR!   dev @swc/core@"^1.2.173" from the root project
    npm ERR!   peerOptional @swc/core@"^1.2.173" from [email protected]
    npm ERR!   node_modules/nx
    npm ERR!     dev nx@"16.0.0" from the root project
    npm ERR!     3 more (@nrwl/tao, @nx/devkit, @nx/workspace)
    npm ERR!   3 more (ts-node, @swc/jest, swc-loader)
    npm ERR! 
    npm ERR! Conflicting peer dependency: @swc/[email protected]
    npm ERR! node_modules/@swc/helpers
    npm ERR!   peerOptional @swc/helpers@"^0.5.0" from @swc/[email protected]
    npm ERR!   node_modules/@swc/core
    npm ERR!     dev @swc/core@"^1.2.173" from the root project
    npm ERR!     peerOptional @swc/core@"^1.2.173" from [email protected]
    npm ERR!     node_modules/nx
    npm ERR!       dev nx@"16.0.0" from the root project
    npm ERR!       3 more (@nrwl/tao, @nx/devkit, @nx/workspace)
    npm ERR!     3 more (ts-node, @swc/jest, swc-loader)
    npm ERR! 
    npm ERR! Fix the upstream dependency conflict, or retry
    npm ERR! this command with --force or --legacy-peer-deps
    npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

@vercel
Copy link

vercel bot commented Apr 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2023 6:46pm

@AgentEnder
Copy link
Member

I was looking at this at the end of Friday- thanks for taking care of it.

@AgentEnder AgentEnder enabled auto-merge (squash) April 17, 2023 15:13
@barbados-clemens
Copy link
Contributor

does webpack/js also need to bump versions?

https://github.com/nrwl/nx/blob/master/packages/js/src/utils/versions.ts#L8
https://github.com/nrwl/nx/blob/master/packages/webpack/src/utils/versions.ts#L4

@jaysoo jaysoo force-pushed the feat/update-swc-helpers branch from 6af5964 to 45a3c73 Compare April 17, 2023 17:20
@jaysoo
Copy link
Member Author

jaysoo commented Apr 17, 2023

I'll push a PR for the version.ts files too.

The main problem was that we used ~ for core and ^ for helpers, which I think was my fault. According to semver ~ for pre 1.0.0 releases behave the same as ^ for 1.0.0 releases, so there's no reason to use different ranges.

@jaysoo jaysoo force-pushed the feat/update-swc-helpers branch 2 times, most recently from 7fb736c to 07dfae5 Compare April 17, 2023 18:13
@AgentEnder AgentEnder merged commit df81c0d into nrwl:master Apr 17, 2023
@jaysoo jaysoo deleted the feat/update-swc-helpers branch April 17, 2023 20:22
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants