Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): use the module name as the name of the nx plugin #16335

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

Cammisuli
Copy link
Member

@Cammisuli Cammisuli commented Apr 17, 2023

Current Behavior

The fall back of getting the name of a registered nx.json plugin defaults to "index.js" after it cannot find the package.json.

>  NX   Failed to process the project graph with "index.js".

   Source project nx does not have a file: C:\dev\nx\packages\nx\Cargo.toml

Expected Behavior

Since we already have the module name of the plugin, using the module name instead of using the base file name is more descriptive.

>  NX   Failed to process the project graph with "@monodon/rust".

   Source project nx does not have a file: C:\dev\nx\packages\nx\Cargo.toml

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Apr 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Apr 17, 2023 11:57am

@Cammisuli Cammisuli force-pushed the use_modulename_for_pluginname branch from 1b75d25 to 3c6c3e6 Compare April 17, 2023 11:57
@FrozenPandaz FrozenPandaz merged commit fa40367 into nrwl:master Apr 17, 2023
@Cammisuli Cammisuli deleted the use_modulename_for_pluginname branch April 17, 2023 14:58
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants