Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vite): add --testFile argument to @nrwl/vite:test #16324

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

liammcateer
Copy link
Contributor

@liammcateer liammcateer commented Apr 16, 2023

closed #16280

Current Behavior

When running the @nrwl/vite:test executor, we don't currently have the option to run a specific test file.

Expected Behavior

After this change, @nrwl/vite:test will have a new option --testFile available, which can be used to run a single test file.

Related Issue(s)

#16280
Fixes #

@vercel
Copy link

vercel bot commented Apr 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2023 7:44pm

Copy link
Contributor

@barbados-clemens barbados-clemens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, I left some comments on the arg naming.

and unsure where this arg should be passed. I'd assume it's in the settings passed to vitest as i'm unsure how you'd actually pass args to vitest cli to the cliFilter parameter.

@mandarini
Copy link
Member

mandarini commented Apr 26, 2023

Hi there @liammcateer ! Thank you for your PR! I think it looks good!

Copy link
Member

@mandarini mandarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liammcateer thanks! :)

@mandarini mandarini force-pushed the feat/vitest-test-files-argument branch from 46dec09 to 85ad3b0 Compare April 26, 2023 19:39
@mandarini mandarini enabled auto-merge (squash) April 26, 2023 19:39
@mandarini mandarini self-assigned this Apr 26, 2023
@github-actions
Copy link

github-actions bot commented May 2, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

running @nrwl/vite:test with single file or list of files
3 participants