Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): correctly pass resolved compilerOptions to ts-node #16240

Merged
merged 1 commit into from
Apr 12, 2023
Merged

fix(core): correctly pass resolved compilerOptions to ts-node #16240

merged 1 commit into from
Apr 12, 2023

Conversation

mattlewis92
Copy link
Contributor

Current Behavior

Linting using custom workspace rules in webstorm is broken:
CleanShot 2023-04-11 at 17 03 37@2x

The regression was introduced in this commit which removed the hard coding of module: commonjs in favor of using the config from tsconfig.json:
b2df831#diff-2851f63978cee5996bae7a52b7ce339437421238099e62883d06fd64f3672bd6L46-L48

However due to the type of the config passed to parseJsonConfigFileContent being any a regression was introduced which passed an empty object as the compiler options instead of the actual compiler options.

When testing the fix on our application we ran into further issues due to the jsx + lib options being set in the custom workspace rules tsconfig so I added a fix for that as well.

Expected Behavior

Linting using custom workspace rules in webstorm works

Related Issue(s)

N/A

@vercel
Copy link

vercel bot commented Apr 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 12, 2023 0:13am

@AgentEnder AgentEnder merged commit 98b4aa6 into nrwl:master Apr 12, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants