fix(core): correctly pass resolved compilerOptions to ts-node #16240
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Linting using custom workspace rules in webstorm is broken:
The regression was introduced in this commit which removed the hard coding of
module: commonjs
in favor of using the config fromtsconfig.json
:b2df831#diff-2851f63978cee5996bae7a52b7ce339437421238099e62883d06fd64f3672bd6L46-L48
However due to the type of the config passed to
parseJsonConfigFileContent
beingany
a regression was introduced which passed an empty object as the compiler options instead of the actual compiler options.When testing the fix on our application we ran into further issues due to the
jsx
+lib
options being set in the custom workspace rulestsconfig
so I added a fix for that as well.Expected Behavior
Linting using custom workspace rules in webstorm works
Related Issue(s)
N/A