Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@nrwl/react-native] listDevices option in the run-android command is not configurable #16221

Closed
skoob13 opened this issue Apr 11, 2023 · 2 comments · Fixed by #16410
Closed
Labels
outdated scope: react-native Issues relating to React Native type: bug

Comments

@skoob13
Copy link

skoob13 commented Apr 11, 2023

Current Behavior

listDevices option of the run-android executor in the React Native package is a flag and it doesn't accept a boolean value, e.g. --list-devices false doesn't skip listing devices. Currently, listDevices set to false by default, so there isn't a way to disable this option because it is always passed to the React Native CLI. The executor asks to select a device every time when I run this command.

Expected Behavior

listDevices should be optional in schema.json, so the device selection step can be skipped.

GitHub Repo

No response

Steps to Reproduce

  1. create a NX project with React Native
  2. execute nx run project:run-android
  3. observe that the device selection is required despite the fact that it is false in the schema.

Nx Report

Node : 16.17.0
   OS   : darwin x64
   yarn : 1.22.19

   nx                      : 15.9.2
   @nrwl/js                : 15.9.2
   @nrwl/jest              : 15.9.2
   @nrwl/linter            : 15.9.2
   @nrwl/workspace         : 15.9.2
   @nrwl/cli               : 15.9.2
   @nrwl/cypress           : 15.9.2
   @nrwl/detox             : 15.9.2
   @nrwl/devkit            : 15.9.2
   @nrwl/eslint-plugin-nx  : 15.9.2
   @nrwl/next              : 15.9.2
   @nrwl/node              : 15.9.2
   @nrwl/react             : 15.9.2
   @nrwl/react-native      : 15.9.2
   @nrwl/tao               : 15.9.2
   @nrwl/web               : 15.9.2
   @nrwl/webpack           : 15.9.2
   typescript              : 4.9.5

Failure Logs

No response

Additional Information

No response

@AgentEnder AgentEnder added the scope: react-native Issues relating to React Native label Apr 11, 2023
@omniviewsports
Copy link

@skoob13 - I encountered the same problem

@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated scope: react-native Issues relating to React Native type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants