fix(misc): shared deps that rely on default configuration are filtered out #16193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d out The issue was introduced by nrwl#15654. It then filters out and omits shared deps that rely on default configuration when return value from `shared` function is `undefined`. closed nrwl#15811
dmarcautan
requested review from
jaysoo,
ndcunningham,
mandarini,
xiongemi,
Coly010 and
leosvelperez
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
leosvelperez
approved these changes
Apr 11, 2023
mandarini
approved these changes
Apr 11, 2023
FrozenPandaz
pushed a commit
that referenced
this pull request
Apr 11, 2023
…d out (#16193) Co-authored-by: Dmitry Marcautan <[email protected]> (cherry picked from commit 432e074)
|
Thank you so much for this one! I think this will solve my problem where I haven't been able to update my project beyond |
|
Just tried out the beta and it seems to solve the issue! Thank you so much! |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was introduced by #15654. It then filters out and omits shared deps that rely on default configuration when return value from
sharedfunction isundefined.Current Behavior
NPM package dependencies are not made shared in module federation configuration when are not explicitly excluded in user provided
sharedfunction by returningundefinedvalueExpected Behavior
NPM package dependencies should be made shared in module federation configuration unless
sharedfunction returnsfalsevalueRelated Issue(s)
Fixes #15811