Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): merge reporter/coverage values from vite config #16165

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

barbados-clemens
Copy link
Contributor

Current Behavior

defining vitest reporters in vite config do not apply

Expected Behavior

defining options in vite config should apply

Related Issue(s)

Fixes #15511

@vercel
Copy link

vercel bot commented Apr 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Apr 6, 2023 7:20pm

@barbados-clemens barbados-clemens self-assigned this Apr 6, 2023
@barbados-clemens barbados-clemens added scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx scope: js labels Apr 6, 2023
@barbados-clemens barbados-clemens marked this pull request as ready for review April 6, 2023 19:21
@mandarini mandarini merged commit 9ba8444 into nrwl:master Apr 7, 2023
@barbados-clemens barbados-clemens deleted the fix/vitest-overrides branch April 7, 2023 17:08
FrozenPandaz pushed a commit that referenced this pull request Apr 11, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: js scope: testing tools Issues related to Cypress / Jest / Playwright / Vitest support in Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vitest junit reporter does not produce output
2 participants