Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): fix migrations cli type and use @angular-devkit/build-angular to determine ng devkit version #16157

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Apr 6, 2023

Current Behavior

A couple of migrations that were recently rewritten using the Nx DevKit still have their cli type as ng.

The migration installing the required peer deps uses the @angular/cli package to determine the version to use for those packages, but we don't bump the @angular/cli version automatically. We only update the @angular/cli package version in migration generators that run after the migration installing the peer deps. As such, an old version of the @angular/cli package is picked up.

Expected Behavior

Migrations written with the Nx DevKit should have the cli type set as nx.

The migration installing the required peer deps sets the correct version of the Angular DevKit. Instead of using the @angular/cli package as reference, it should use the @angular-devkit/build-angular.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Apr 6, 2023
@vercel
Copy link

vercel bot commented Apr 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Apr 6, 2023 11:45am

@leosvelperez leosvelperez marked this pull request as ready for review April 6, 2023 12:06
@leosvelperez leosvelperez requested a review from Coly010 as a code owner April 6, 2023 12:06
@FrozenPandaz FrozenPandaz merged commit e9f97f8 into nrwl:master Apr 6, 2023
@leosvelperez leosvelperez deleted the angular/migration-fixes branch April 6, 2023 14:06
FrozenPandaz pushed a commit that referenced this pull request Apr 11, 2023
…ngular to determine ng devkit version (#16157)

(cherry picked from commit e9f97f8)
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants