fix(angular): fix migrations cli type and use @angular-devkit/build-angular to determine ng devkit version #16157
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
A couple of migrations that were recently rewritten using the Nx DevKit still have their
cli
type asng
.The migration installing the required peer deps uses the
@angular/cli
package to determine the version to use for those packages, but we don't bump the@angular/cli
version automatically. We only update the@angular/cli
package version in migration generators that run after the migration installing the peer deps. As such, an old version of the@angular/cli
package is picked up.Expected Behavior
Migrations written with the Nx DevKit should have the
cli
type set asnx
.The migration installing the required peer deps sets the correct version of the Angular DevKit. Instead of using the
@angular/cli
package as reference, it should use the@angular-devkit/build-angular
.Related Issue(s)
Fixes #