-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react-native): add aliasFields to handle replaced files in browser env #16106
Merged
xiongemi
merged 2 commits into
nrwl:master
from
Singloo:bug-fix/fix-rn-pnpm-resolver-alias
Apr 6, 2023
Merged
fix(react-native): add aliasFields to handle replaced files in browser env #16106
xiongemi
merged 2 commits into
nrwl:master
from
Singloo:bug-fix/fix-rn-pnpm-resolver-alias
Apr 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Singloo
changed the title
Bug fix/fix rn pnpm resolver alias
Bug fix/fix rn pnpm resolver alias fields
Apr 5, 2023
xiongemi
approved these changes
Apr 5, 2023
xiongemi
changed the title
Bug fix/fix rn pnpm resolver alias fields
fix(react-native): add aliasFields to handle replaced files in browser env
Apr 5, 2023
xiongemi
approved these changes
Apr 5, 2023
@Singloo the pr looks good. however, the ci check failed. could you rebase and trigger the ci to run again? |
Singloo
force-pushed
the
bug-fix/fix-rn-pnpm-resolver-alias
branch
from
April 6, 2023 01:53
f0d2b29
to
bb20ad1
Compare
@xiongemi done |
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
browser field in
package.json
can be an object, hints some files need to be replaced when packaging. Currently, pnpm module resolver doesn't do the file replacements.e.g.
When resolving picocolors, module resolver resolves to the wrong entry file.
Current behavior:
…/node_modules/picocolors/picocolors.js
Picocolors has the following package.json
Expected Behavior
Should resolve to
…/node_modules/picocolors/picocolors.browser.js
Related Issue(s)
Fixes #16105