Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): fix path handling and validate standalone option in pipe generator #16080

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Apr 4, 2023

Current Behavior

The pipe generator:

  • doesn't add the app or lib segment to the path based on the project type
  • doesn't validate the standalone option support

Expected Behavior

The pipe generator builds correctly the path and validates the standalone option support.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Apr 4, 2023
@vercel
Copy link

vercel bot commented Apr 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2023 9:31am

@nx-cloud
Copy link

nx-cloud bot commented Apr 4, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4411c96. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@leosvelperez leosvelperez marked this pull request as ready for review April 4, 2023 10:18
@leosvelperez leosvelperez requested a review from Coly010 as a code owner April 4, 2023 10:19
@leosvelperez leosvelperez merged commit 74633f5 into nrwl:master Apr 4, 2023
@leosvelperez leosvelperez deleted the angular/pipe-fixes branch April 4, 2023 10:28
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants