Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): validate standalone option in the directive generator #16051

Conversation

leosvelperez
Copy link
Member

Current Behavior

The directive generator doesn't validate the standalone option for Angular versions that don't support it (<14.1.0).

Expected Behavior

The directive generator should validate the standalone option for Angular versions that don't support it (<14.1.0).

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Apr 3, 2023
@vercel
Copy link

vercel bot commented Apr 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2023 9:49am

@leosvelperez leosvelperez marked this pull request as ready for review April 3, 2023 10:09
@leosvelperez leosvelperez requested a review from Coly010 as a code owner April 3, 2023 10:09
@leosvelperez leosvelperez enabled auto-merge (squash) April 3, 2023 11:01
@leosvelperez leosvelperez merged commit bf9542a into nrwl:master Apr 3, 2023
@leosvelperez leosvelperez deleted the angular/directive-standalone-validation branch April 3, 2023 13:54
@github-actions
Copy link

github-actions bot commented Apr 9, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants