Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): remove thirdParty default so that package.json will be generated by default #16015

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

ndcunningham
Copy link
Contributor

closed #15954
Remove the defaulted --third-party=true

If you provide --third-party=true --bundle=false you will now get a warning message

Screen.Recording.2023-03-31.at.10.36.56.AM.mov

@vercel
Copy link

vercel bot commented Mar 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 31, 2023 at 5:31PM (UTC)

@jaysoo jaysoo merged commit c02ec9f into nrwl:master Apr 4, 2023
@ndcunningham ndcunningham deleted the fix/issue-15954 branch April 4, 2023 14:55
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing dependencies in generated package.json when building Express application
2 participants