feat(core): update create-nx-plugin to generate cli library #15994

xiongemi · 2023-03-31T02:48:42Z

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

vercel · 2023-03-31T02:48:46Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nx-dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 19, 2023 11:14pm

nx-cloud · 2023-03-31T02:50:28Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8cd1dc4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 8 targets

Sent with 💌 from NxCloud.

AgentEnder

This PR has a lot of overlap with my pr, #15743

Since that PR changes the entire body of create nx plugin out, we should probably hold off on this one until it's merged

packages/create-nx-workspace/package.json

FrozenPandaz · 2023-04-19T19:07:57Z

docs/generated/packages/jest/executors/jest.json

@@ -110,7 +110,8 @@
      "runInBand": {
        "alias": "i",
        "description": "Run all tests serially in the current process (rather than creating a worker pool of child processes that run tests). This is sometimes useful for debugging, but such use cases are pretty rare. Useful for CI. (https://jestjs.io/docs/cli#--runinband)",
-        "type": "boolean"
+        "type": "boolean",
+        "default": true


This is the wrong place, we want to change @nx/nx-plugin:e2e

thinking on this after a couple minutes.
if the @nx/nx-plugin:e2e executor doesn't really work without jest set to runInBand. then it would make sense to just leave it hard coded and not let people opt out of it.
I thought it might have just been a perf thing or whatever.

If we do add it as an executor option, then probably explain that the tests will probably start failing if you turn this off.

Theres ways for it to still work, we need to take another look at our e2e utils

FrozenPandaz · 2023-04-19T19:11:05Z

e2e/workspace-create/src/create-nx-plugin.test.ts

@@ -21,6 +21,7 @@ describe('create-nx-plugin', () => {

    runCreatePlugin(pluginName, {
      packageManager,
+      extraArgs: `--createPackageName=create-${pluginName}-package`,


Create a separate test for this.

FrozenPandaz · 2023-04-19T19:13:36Z

packages/nx-plugin/src/generators/create-package/create-package.ts

+  schema: NormalizedSchema
+): Promise<string> {
+  const { root: projectRoot } = readProjectConfiguration(host, schema.project);
+  try {


Use hasGenerator

We reviewed together.

@nx

Squashed commit of the following: commit a51ac58 Author: Miroslav Jonaš <[email protected]> Date: Thu Apr 20 09:16:45 2023 +0200 fix(core): do not expect each package to have hoisted version in lockfile (nrwl#16393) commit 4a4fc19 Author: Miroslav Jonaš <[email protected]> Date: Thu Apr 20 09:16:32 2023 +0200 fix(core): enforce fixed versions only for apps with createPackageJson (nrwl#16398) commit 8400484 Author: Emily Xiong <[email protected]> Date: Wed Apr 19 20:36:11 2023 -0400 feat(core): update create-nx-plugin to generate cli library (nrwl#15994) commit 16e4061 Author: Craigory Coppola <[email protected]> Date: Wed Apr 19 18:25:41 2023 -0400 feat(devkit): bump support range to be 15 <= x <= 17 (nrwl#16421) commit fc07794 Author: Craigory Coppola <[email protected]> Date: Wed Apr 19 18:07:56 2023 -0400 feat(core): remove deprecated affected commands (nrwl#16349) commit a798576 Author: Craigory Coppola <[email protected]> Date: Wed Apr 19 17:02:34 2023 -0400 fix(misc): pass e2eTestRunner to child preset generator (nrwl#16414) commit 338dc64 Author: Nicholas Cunningham <[email protected]> Date: Wed Apr 19 13:29:31 2023 -0600 feat(nextjs): Add standalone Nextjs option to react selection when running CNW (nrwl#16317) commit 16e115f Author: Emily Xiong <[email protected]> Date: Wed Apr 19 15:03:36 2023 -0400 fix(react-native): log errors for pod install (nrwl#16386) commit 0fc3d44 Author: FrozenPandaz <[email protected]> Date: Wed Apr 19 14:24:10 2023 -0400 chore(misc): publish 16.0.0-beta.4 commit f7ca6e6 Author: Craigory Coppola <[email protected]> Date: Wed Apr 19 14:21:30 2023 -0400 chore(misc): update migration version for workspace-generator (nrwl#16417) commit b3ca503 Author: Craigory Coppola <[email protected]> Date: Wed Apr 19 14:12:09 2023 -0400 fix(core): hide duplicate log entry when displaying generator help (nrwl#16353) commit 9fa6d41 Author: Craigory Coppola <[email protected]> Date: Wed Apr 19 14:06:57 2023 -0400 fix(misc): mark workspace-lint as deprecated in yargs config (nrwl#16385) commit 9c9abaa Author: Emily Xiong <[email protected]> Date: Wed Apr 19 14:03:45 2023 -0400 fix(react-native): remove listDevices default value for run-android (nrwl#16410) commit 1743ff1 Author: Craigory Coppola <[email protected]> Date: Wed Apr 19 14:03:00 2023 -0400 feat(core): add migration to update workspace generators to a local plugin (nrwl#12700) commit f04f316 Author: Jack Hsu <[email protected]> Date: Wed Apr 19 14:00:24 2023 -0400 feat(react): add rspack experimental support (nrwl#16252) commit 1ff450b Author: Jason Jean <[email protected]> Date: Wed Apr 19 13:43:44 2023 -0400 fix(core): fix devkit compatibility (nrwl#16413) commit 6677a9c Author: Leosvel Pérez Espinosa <[email protected]> Date: Wed Apr 19 18:32:51 2023 +0100 feat(misc): expose nx init command flags (nrwl#16287) commit 5d7ad34 Author: Leosvel Pérez Espinosa <[email protected]> Date: Wed Apr 19 18:22:52 2023 +0100 feat(testing): bump ts-jest to 29.1.0 to support typescript 5.x (nrwl#16401) commit a8e85da Author: Dominik Pieper <[email protected]> Date: Wed Apr 19 19:01:50 2023 +0200 feat(testing): export cypressE2EConfigurationGenerator (nrwl#16394) commit 1ad7e3d Author: Caleb Ukle <[email protected]> Date: Wed Apr 19 11:55:11 2023 -0500 fix(testing): nullcheck polyfills in ng component testing (nrwl#16411) commit c963393 Author: Katerina Skroumpelou <[email protected]> Date: Wed Apr 19 19:34:38 2023 +0300 fix(storybook): dont use swc addon on sb7 and format (nrwl#16408) commit c8960b7 Author: Miroslav Jonaš <[email protected]> Date: Wed Apr 19 17:13:10 2023 +0200 fix(linter): don't confuse buildable libs for secondary ng entry point (nrwl#16367) commit 2734401 Author: FrozenPandaz <[email protected]> Date: Wed Apr 19 11:10:19 2023 -0400 chore(misc): publish 16.0.0-beta.3 commit da158bc Author: Jason Jean <[email protected]> Date: Wed Apr 19 10:59:58 2023 -0400 feat(angular): replace usages of @nrwl with @nx (nrwl#16377) Co-authored-by: Colum Ferry <[email protected]> commit 76dfc62 Author: Jason Jean <[email protected]> Date: Wed Apr 19 10:59:41 2023 -0400 feat(web): replace usages of @nrwl with @nx (nrwl#16376) commit 1780aac Author: Jack Hsu <[email protected]> Date: Wed Apr 19 10:57:34 2023 -0400 feat(react): add @nx/web as a dependency since it is needed by cypress/etc. (nrwl#16407) commit 52acf07 Author: Jason Jean <[email protected]> Date: Wed Apr 19 10:40:37 2023 -0400 fix(angular): fix resolve builder in ngcli adapter (nrwl#16375) commit ab609a2 Author: Jack Hsu <[email protected]> Date: Wed Apr 19 10:38:01 2023 -0400 fix(js): update swc options so path mappings can work in all environments (nrwl#16390) commit 157b35b Author: Katerina Skroumpelou <[email protected]> Date: Wed Apr 19 17:33:10 2023 +0300 fix(storybook): do not override existing v7 on init (nrwl#16405)

github-actions · 2023-04-26T00:07:00Z

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

xiongemi requested review from FrozenPandaz, vsavkin, meeroslav, AgentEnder, jaysoo, ndcunningham, bcabanes, isaacplmann, juristr and JamesHenry as code owners March 31, 2023 02:48

vercel bot deployed to Preview March 31, 2023 02:50 View deployment

xiongemi force-pushed the feat/update-nx-create-plugin branch from d63ee15 to daa956c Compare March 31, 2023 02:59

vercel bot deployed to Preview March 31, 2023 03:03 View deployment

xiongemi force-pushed the feat/update-nx-create-plugin branch from daa956c to 626606d Compare March 31, 2023 03:29

vercel bot deployed to Preview March 31, 2023 03:32 View deployment

xiongemi force-pushed the feat/update-nx-create-plugin branch from 626606d to 034b99c Compare March 31, 2023 03:59

vercel bot deployed to Preview March 31, 2023 04:02 View deployment

xiongemi force-pushed the feat/update-nx-create-plugin branch from 034b99c to 3d255c1 Compare March 31, 2023 05:02

vercel bot deployed to Preview March 31, 2023 05:05 View deployment

xiongemi force-pushed the feat/update-nx-create-plugin branch from 3d255c1 to 71e8228 Compare March 31, 2023 05:39

vercel bot deployed to Preview March 31, 2023 05:43 View deployment

AgentEnder requested changes Mar 31, 2023

View reviewed changes

xiongemi force-pushed the feat/update-nx-create-plugin branch from 71e8228 to f996a7a Compare April 3, 2023 18:46

xiongemi requested a review from mandarini as a code owner April 3, 2023 18:46

vercel bot deployed to Preview April 3, 2023 18:53 View deployment

AgentEnder reviewed Apr 3, 2023

View reviewed changes

packages/create-nx-workspace/package.json Show resolved Hide resolved

xiongemi force-pushed the feat/update-nx-create-plugin branch from f996a7a to 5871ba6 Compare April 3, 2023 22:12

vercel bot deployed to Preview April 3, 2023 22:16 View deployment

xiongemi force-pushed the feat/update-nx-create-plugin branch from 80bc0c2 to 68d5ad0 Compare April 19, 2023 17:41

vercel bot deployed to Preview April 19, 2023 17:53 View deployment

xiongemi force-pushed the feat/update-nx-create-plugin branch from 68d5ad0 to 96ac657 Compare April 19, 2023 18:33

xiongemi requested a review from nartc as a code owner April 19, 2023 18:33

vercel bot deployed to Preview April 19, 2023 18:37 View deployment

xiongemi force-pushed the feat/update-nx-create-plugin branch from 96ac657 to cf6e180 Compare April 19, 2023 18:37

vercel bot deployed to Preview April 19, 2023 18:41 View deployment

xiongemi force-pushed the feat/update-nx-create-plugin branch from cf6e180 to 9e478e4 Compare April 19, 2023 19:11

vercel bot deployed to Preview April 19, 2023 19:14 View deployment

FrozenPandaz requested changes Apr 19, 2023

View reviewed changes

xiongemi force-pushed the feat/update-nx-create-plugin branch from 9e478e4 to 26963db Compare April 19, 2023 19:28

vercel bot deployed to Preview April 19, 2023 19:32 View deployment

xiongemi added 2 commits April 19, 2023 16:21

feat(core): update create-nx-plugin to generate cli library

86dd385

feat(misc): update pr with comments

934847b

xiongemi force-pushed the feat/update-nx-create-plugin branch from 26963db to 05f4ebc Compare April 19, 2023 20:22

vercel bot deployed to Preview April 19, 2023 20:25 View deployment

xiongemi force-pushed the feat/update-nx-create-plugin branch from 05f4ebc to b5ec700 Compare April 19, 2023 20:52

vercel bot deployed to Preview April 19, 2023 20:55 View deployment

FrozenPandaz approved these changes Apr 19, 2023

View reviewed changes

xiongemi force-pushed the feat/update-nx-create-plugin branch from b5ec700 to ab1b9d5 Compare April 19, 2023 22:03

vercel bot deployed to Preview April 19, 2023 22:06 View deployment

feat(misc): update pr with comments

8cd1dc4

xiongemi force-pushed the feat/update-nx-create-plugin branch from ab1b9d5 to 8cd1dc4 Compare April 19, 2023 23:10

vercel bot deployed to Preview April 19, 2023 23:14 View deployment

FrozenPandaz merged commit 8400484 into master Apr 20, 2023

FrozenPandaz deleted the feat/update-nx-create-plugin branch April 20, 2023 00:36

github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(core): update create-nx-plugin to generate cli library #15994

feat(core): update create-nx-plugin to generate cli library #15994

xiongemi commented Mar 31, 2023

vercel bot commented Mar 31, 2023 •

edited

Loading

nx-cloud bot commented Mar 31, 2023 •

edited

Loading

AgentEnder left a comment

FrozenPandaz Apr 19, 2023

barbados-clemens Apr 19, 2023

AgentEnder Apr 19, 2023

FrozenPandaz Apr 19, 2023

FrozenPandaz Apr 19, 2023

github-actions bot commented Apr 26, 2023

feat(core): update create-nx-plugin to generate cli library #15994

feat(core): update create-nx-plugin to generate cli library #15994

Conversation

xiongemi commented Mar 31, 2023

Current Behavior

Expected Behavior

Related Issue(s)

vercel bot commented Mar 31, 2023 • edited Loading

nx-cloud bot commented Mar 31, 2023 • edited Loading

☁️ Nx Cloud Report

AgentEnder left a comment

Choose a reason for hiding this comment

FrozenPandaz Apr 19, 2023

Choose a reason for hiding this comment

barbados-clemens Apr 19, 2023

Choose a reason for hiding this comment

AgentEnder Apr 19, 2023

Choose a reason for hiding this comment

FrozenPandaz Apr 19, 2023

Choose a reason for hiding this comment

FrozenPandaz Apr 19, 2023

Choose a reason for hiding this comment

github-actions bot commented Apr 26, 2023

vercel bot commented Mar 31, 2023 •

edited

Loading

nx-cloud bot commented Mar 31, 2023 •

edited

Loading