fix(webpack): web app in default nx config not working with @aws-sdk #15962
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
web apps created via default NX configurations won't work with @aws-sdk
the reason is that all AWS SKD v3 packages define only partial entry via
browser
, and the rest via eithermodule
for browser, ormain
for node.jswith default NX
withWeb
settings, which inherit fromwithNX
settings, the order will bebrowser
,main
, andmodule
, in the case of AWS SDK, webpack will wrongly import most of the node.js packages instead of browser oriented packages.I do not see a reason why this shouldn't be overwritten in
withWeb
config to letmodule
takes priority. Thus the changes in this PR did it.Expected Behavior
should work with AWS SDK (and potentially other open source libraries uses similar strategy as AWS SDK
Related Issue(s)
#14920
Fixes #14920