Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nx-dev): add table of content for documents #15910

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

bcabanes
Copy link
Member

It adds a table of content on the right side of documents for large viewports.

@bcabanes bcabanes self-assigned this Mar 27, 2023
@vercel
Copy link

vercel bot commented Mar 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 31, 2023 at 3:58PM (UTC)

@nx-cloud
Copy link

nx-cloud bot commented Mar 27, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9d2ba28. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@bcabanes bcabanes force-pushed the feat/nx-dev/toc branch 2 times, most recently from dc2502b to cab0154 Compare March 28, 2023 14:31
@bcabanes bcabanes requested a review from juristr March 28, 2023 14:31
@bcabanes bcabanes marked this pull request as ready for review March 28, 2023 14:32
@bcabanes bcabanes requested a review from isaacplmann as a code owner March 28, 2023 14:32
@bcabanes bcabanes enabled auto-merge (squash) March 31, 2023 14:45
Copy link
Member

@juristr juristr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a bit weird in dark mode

image

Optional improvement

  • can we somehow specify on a page to not have a TOC? Thinking like on the main docs entry page where it might not be necessary

nx-dev/feature-doc-viewer/src/lib/table-of-contents.tsx Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants