feat(angular): support angular v16 #15592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
leosvelperez
force-pushed
the
angular/v16-support
branch
from
471ddd6 to
2c95bd3
Compare
leosvelperez
force-pushed
the
angular/v16-support
branch
from
2c95bd3 to
dce04e9
Compare
leosvelperez
force-pushed
the
angular/v16-support
branch
from
dce04e9 to
4e478a7
Compare
leosvelperez
force-pushed
the
angular/v16-support
branch
from
4e478a7 to
283f16a
Compare
leosvelperez
force-pushed
the
angular/v16-support
branch
from
283f16a to
2b606ac
Compare
leosvelperez
force-pushed
the
angular/v16-support
branch
from
2b606ac to
7de35bc
Compare
leosvelperez
force-pushed
the
angular/v16-support
branch
from
7de35bc to
93e581f
Compare
leosvelperez
force-pushed
the
angular/v16-support
branch
from
93e581f to
0fcf0ac
Compare
leosvelperez
force-pushed
the
angular/v16-support
branch
from
0fcf0ac to
0874034
Compare
leosvelperez
force-pushed
the
angular/v16-support
branch
from
0874034 to
6c38908
Compare
leosvelperez
force-pushed
the
angular/v16-support
branch
from
6c38908 to
78802ee
Compare
leosvelperez
force-pushed
the
angular/v16-support
branch
2 times, most recently
from
96b6d17 to
45b3dae
Compare
leosvelperez
force-pushed
the
angular/v16-support
branch
from
45b3dae to
67135d9
Compare
leosvelperez
force-pushed
the
angular/v16-support
branch
from
c1f7a63 to
d872606
Compare
leosvelperez
force-pushed
the
angular/v16-support
branch
from
d872606 to
3da9986
Compare
FrozenPandaz
requested review from
FrozenPandaz,
AgentEnder,
vsavkin,
jaysoo,
Coly010,
mandarini,
meeroslav,
JamesHenry,
barbados-clemens,
ndcunningham,
nartc,
xiongemi,
philipjfulcher and
bcabanes
as code owners
FrozenPandaz
approved these changes
May 3, 2023
AhsanAyaz
reviewed
May 7, 2023
| provideRouter, | ||
| withEnabledBlockingInitialNavigation, | ||
| } from '@angular/router'; | ||
| import { appRoutes } from './app/app.routes'; |
There was a problem hiding this comment.
@leosvelperez shouldn't this be import { appRoutes } from './app.routes'; instead since the file app.config.ts is already inside the app folder ?
I haven't ran the tests but wondering how they're passing.
I migrated my nx repository and am getting the errors as expected.
I can create a PR if you'd like 🙂
AhsanAyaz
reviewed
May 7, 2023
There was a problem hiding this comment.
Hey @leosvelperez ! I found an issue while migrating a big nx 15.x Angular repository.
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Angular v15.2.x is the latest supported version.
Expected Behavior
Angular v16.0.x should be supported.
Related Issue(s)
Fixes #