fix(testing): support custom workspaceRoot for angular CT #15485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
3 tasks
barbados-clemens
force-pushed
the
fix/use-custom-workspace-root-angular-ct
branch
5 times, most recently
from
3952efc to
e639839
Compare
barbados-clemens
requested review from
FrozenPandaz,
vsavkin,
jaysoo,
leosvelperez and
Coly010
as code owners
barbados-clemens
force-pushed
the
fix/use-custom-workspace-root-angular-ct
branch
from
e639839 to
95dc7bd
Compare
leosvelperez
approved these changes
Apr 12, 2023
FrozenPandaz
approved these changes
Apr 14, 2023
peppoasap
pushed a commit
to peppoasap/nx
that referenced
this pull request
Apr 18, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Unable to read root level files from the angular CT (i.e. tailwind configs in the workspaceRoot)
Expected Behavior
Nx preset passes the workspaceRoot to cypress to correct configure angular webpack
This fix requires a PR to cypress to be released.
cypress-io/cypress#26030
And nx should handle both code paths so if there is a non supported cypress version things keep working as they were before with an 'offset' but when a version of cypress that uses the custom workspaceRoot then the offsets aren't needed
Related Issue(s)
Fixes #12113
TODO: