-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(testing): correctly error with jest.mock for invalid filepaths #15445
Merged
FrozenPandaz
merged 1 commit into
nrwl:master
from
barbados-clemens:fix/jest-resolve-correct-dir
Apr 6, 2023
Merged
fix(testing): correctly error with jest.mock for invalid filepaths #15445
FrozenPandaz
merged 1 commit into
nrwl:master
from
barbados-clemens:fix/jest-resolve-correct-dir
Apr 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
barbados-clemens
force-pushed
the
fix/jest-resolve-correct-dir
branch
from
March 15, 2023 07:09
646115d
to
5580440
Compare
barbados-clemens
added
the
scope: testing tools
Issues related to Cypress / Jest / Playwright / Vitest support in Nx
label
Mar 17, 2023
barbados-clemens
force-pushed
the
fix/jest-resolve-correct-dir
branch
from
April 3, 2023 15:31
5580440
to
4e3a15b
Compare
barbados-clemens
force-pushed
the
fix/jest-resolve-correct-dir
branch
from
April 5, 2023 16:01
4e3a15b
to
585fe55
Compare
barbados-clemens
changed the title
fix(testing): use rootDir to resolve files with ts
fix(testing): correctly error with jest.mock for invalid filepaths
Apr 5, 2023
barbados-clemens
force-pushed
the
fix/jest-resolve-correct-dir
branch
from
April 5, 2023 16:21
585fe55
to
f06df83
Compare
barbados-clemens
requested review from
vsavkin,
AgentEnder,
jaysoo and
JamesHenry
as code owners
April 5, 2023 16:21
FrozenPandaz
approved these changes
Apr 6, 2023
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
when trying to mock a module that doesn't exit the nx jest resolver will automagically find the file
Expected Behavior
jest correctly throws an error saying the module doesn't exist
Related Issue(s)
Fixes #15312