Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prettier version should upgrade to 1.9 #153

Closed
chgc opened this issue Dec 13, 2017 · 2 comments
Closed

prettier version should upgrade to 1.9 #153

chgc opened this issue Dec 13, 2017 · 2 comments
Labels
outdated type: enhancement

Comments

@chgc
Copy link
Contributor

chgc commented Dec 13, 2017

I am not sure if install prettier as devDependences will effect VSCode Prettier Extension. VSCode keeps complaining about prettier proseWrap options should be boolean not string.

However, in Prettier version 1.9. they change proseWrap option.

[WARNING] proseWrap with boolean value is deprecated, use "always", "never" or "preserve" instead.

Currently, prettier package version in Nx template is 1.8.6. I have to manually upgrade it to 1.9 to solve the problem as I described before.

Reference: Prettier package 1.9 release note
@vsavkin
Copy link
Member

vsavkin commented Dec 14, 2017

@chgc could you submit a PR?

@chgc chgc mentioned this issue Dec 15, 2017
Merged
@chgc chgc closed this as completed Dec 18, 2017
@github-actions
Copy link

This issue has been closed for more than 30 days. If this issue is still occuring, please open a new issue with more recent context.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
outdated type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vsavkin @chgc