Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): hide storybook 7 flags #14568

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

FrozenPandaz
Copy link
Collaborator

Current Behavior

Some flags to opt in to storybook 7 beta are quite visible.

Expected Behavior

The flags to opt in to storybook 7 beta are hidden

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Jan 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 23, 2023 at 10:24PM (UTC)

@AgentEnder
Copy link
Member

@FrozenPandaz is there a follow up item for making these visible again?

@FrozenPandaz FrozenPandaz merged commit 3a8ec4f into nrwl:master Jan 23, 2023
@FrozenPandaz FrozenPandaz deleted the hide-storybook7 branch January 23, 2023 22:49
@FrozenPandaz
Copy link
Collaborator Author

No

@mandarini
I made these flags hidden because I don't think we want people to get used to passing them and it will make it hard to deprecate them later.

@github-actions
Copy link

github-actions bot commented Mar 7, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants