Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): revert to previous defaults for Storybook CLI options #14498

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

mandarini
Copy link
Member

Keep the rules and extensions.

Fixes #14462

@mandarini mandarini requested a review from jaysoo January 19, 2023 15:33
@vercel
Copy link

vercel bot commented Jan 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 19, 2023 at 10:21PM (UTC)

@mandarini mandarini self-assigned this Jan 19, 2023
@mandarini mandarini force-pushed the fix/with-nx-rules branch 2 times, most recently from 431ddc4 to 384d2a9 Compare January 19, 2023 15:46
@mandarini
Copy link
Member Author

Same error even after change :(

Copy link
Contributor

@mthines mthines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Shouldn't make much of a difference, but the nullish coalescing operator ?? shouldn't make a difference in this case so I would just have had used the ||. :)

@mandarini
Copy link
Member Author

@mthines it does not seem to solve the issue, unfortunately!

@mthines
Copy link
Contributor

mthines commented Jan 19, 2023

@mthines it does not seem to solve the issue, unfortunately!

@mandarini

I will investigate the matter myself tomorrow ☺️

@jaysoo
Copy link
Member

jaysoo commented Jan 19, 2023

Taking a look

@jaysoo jaysoo force-pushed the fix/with-nx-rules branch 2 times, most recently from bd76586 to 00a3be6 Compare January 19, 2023 21:41
@jaysoo
Copy link
Member

jaysoo commented Jan 19, 2023

Updated docs option in our schema to be undefined by default so Storybook can apply its own defaults (which is docs: true).

@jaysoo jaysoo changed the title fix(webpack): add previours rules before adding new fix(storybook): revert to previous defaults for Storybook CLI options Jan 19, 2023
@jaysoo jaysoo force-pushed the fix/with-nx-rules branch from 00a3be6 to 21f2551 Compare January 19, 2023 22:03
@jaysoo jaysoo enabled auto-merge (squash) January 19, 2023 22:03
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storybook React Webpack does not process .mdx files after update to 15.5.2
3 participants