Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(js): move babel preset to @nrwl/js/babel so @nrwl/web is not… #14478

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Jan 18, 2023

… required for JS projects (e.g. React, Node)

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Jan 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 23, 2023 at 3:12PM (UTC)

Copy link
Member

@mandarini mandarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Added a small comment.

@jaysoo jaysoo force-pushed the feat/move-babel-preset-to-js-package branch from 422a685 to 2967cd3 Compare January 23, 2023 14:58
@jaysoo jaysoo enabled auto-merge (squash) January 23, 2023 14:59
… required for JS projects (e.g. React, Node)
@jaysoo jaysoo force-pushed the feat/move-babel-preset-to-js-package branch from 2967cd3 to f0e498a Compare January 23, 2023 15:00
@jaysoo jaysoo disabled auto-merge January 23, 2023 15:25
@jaysoo jaysoo enabled auto-merge (squash) January 23, 2023 15:25
@jaysoo jaysoo merged commit 5e11adb into nrwl:master Jan 23, 2023
@jaysoo jaysoo deleted the feat/move-babel-preset-to-js-package branch January 23, 2023 15:34
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants