Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): react standalone bundler prompt #14464

Merged

Conversation

mandarini
Copy link
Member

If user chooses react-standalone on create-nx-workspace, prompt them choose the bundler, too. Available options vite and webpack. Default is vite.

@mandarini mandarini self-assigned this Jan 18, 2023
@vercel
Copy link

vercel bot commented Jan 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 20, 2023 at 11:23AM (UTC)

@mandarini mandarini requested a review from jaysoo January 18, 2023 16:19
@nx-cloud
Copy link

nx-cloud bot commented Jan 18, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit bc45eb3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


🟥 Failed Commands
nx affected --target=e2e --base=6330d9ec970fd3587a170de489be4559c442edc4 --head=2a5bb2660f538dc1950559c225ac144c6c2c9ac8 --exclude=e2e-storybook,e2e-storybook-angular --parallel=1
✅ Successfully ran 15 targets

Sent with 💌 from NxCloud.

@github-actions
Copy link

github-actions bot commented Mar 9, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants